[Webkit-unassigned] [Bug 45020] Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Tue Sep 7 10:11:05 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45020

Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66604|review?                     |review-
               Flag|                            |

--- Comment #9 from Dave Hyatt <hyatt at apple.com>  2010-09-07 10:11:05 PST ---
(From update of attachment 66604)
(1) You need to move all of the value keywords for writing-mode and block-flow out of SVGCSSValueKeywords.in, so that your code will compile even when ENABLE(SVG) is false.  I'm not sure what some of them are doing in that file anyway.  Just move them all over to the main CSS keywords file.

(2) You need to patch the RenderStyle::diff() method to make sure changes in block-flow trigger a layout.

(3) I'd still like to see computed style support added (CSSComputedStyleDeclaration.cpp).

(4) Once you add computed style support in (3), you can add some layout tests to this patch as well.  I'd suggest fast/text/vertical as a good place for new tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.