[Webkit-unassigned] [Bug 45181] Ignore programmatic clicks on speech input button.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 02:46:02 PDT 2010


--- Comment #11 from Satish Sampath <satish at chromium.org>  2010-09-07 02:46:02 PST ---
(In reply to comment #10)
> (From update of attachment 66639 [details])

I just realised that if the click coordinates no longer point to the speech button, this test would actually pass because it is only checking for the non-occurance of the onchange event. To make sure the coordinates are correct I need to add back the original code to test the success case (which was present in patch 2) so that an eventSender based click at that coordinate succeeds and returns the mock result, while a dispatchEvent based click at the same coordinate does not given an onchange event.

As for the comment, I could just mention in the description that "This test may time out if the calculated coordinates for the click event were incorrect and the speech button is not rendered at that point (i.e. test needs to be updated).". I say time out because the success case mentioned above will time out if the click did not happen on the button and onchange was never called while the script is waiting for it.

Does this sound ok?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list