[Webkit-unassigned] [Bug 44950] [WML] Add create functions to WML

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 01:30:36 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=44950





--- Comment #12 from Dirk Schulze <krit at webkit.org>  2010-09-07 01:30:36 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > (From update of attachment 66688 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=66688&action=prettypatch
> > 
> > > WebCore/wml/WMLFormControlElement.h:33
> > > +    static PassRefPtr<WMLFormControlElement> create(const QualifiedName&, Document*);
> > > +
> > >      WMLFormControlElement(const QualifiedName&, Document*);
> > Did you upload the wrong patch? Still no change here!
> 
> As mentioned in Comment #7, almost create() function is set as public. Should I set the create as private ?

Please read https://bugs.webkit.org/show_bug.cgi?id=44950#c8 again. 'create()' should be public and WMLFormControlElement(const QualifiedName&, Document*); should be private. I even wrote the code down for you. Just copy paste it if you want.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list