[Webkit-unassigned] [Bug 42832] webkit-patch command to find the ports covering a specific layout test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42832





--- Comment #21 from Adam Barth <abarth at webkit.org>  2010-09-07 01:00:01 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > (From update of attachment 66656 [details] [details])
> > > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:239
> > > +    def skipped_layout_tests(self):
> > > +        return [line.split(':')[1].split("=")[0].strip()
> > > +                for line in self.test_expectations().splitlines()
> > > +                if line.find('SKIP') != -1 and not line.startswith('//')]
> > Surely we should use the test_expectation file parser instead of hacking one together here.
> 
> Sure we can use that parser but it's really slow, at least here. Anyway, will make use of it in next patch...

How slow are we talking about?  In general, we don't worry too much about performance of these commands.  Maintainability is usually more important.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.