[Webkit-unassigned] [Bug 44950] [WML] Add create functions to WML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44950


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66643|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Dirk Schulze <krit at webkit.org>  2010-09-06 11:15:14 PST ---
(From update of attachment 66643)
View in context: https://bugs.webkit.org/attachment.cgi?id=66643&action=prettypatch

> WebCore/wml/WMLFormControlElement.h:48
> +    static PassRefPtr<WMLFormControlElement> create(const QualifiedName&, Document*);
My first comment was maybe a bit confusing. 'create' should be public and the CTor should be private :-)

Looks like the WML code is realy bad maintened. Good catches!

Please go a bit more into details in the Changelog. Also mention which commit broke WML and that this patch tries to get WML building again.

You'll get r=me after you uploaded a new version with the changes above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.