[Webkit-unassigned] [Bug 41535] "vertical-align: middle; " not working on a MathML element

Mon Sep 6 10:28:01 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=41535

mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66642|review?                     |review-
               Flag|                            |

--- Comment #5 from mitz at webkit.org  2010-09-06 10:28:01 PST ---
(From update of attachment 66642)
> +        if (static_cast<int>(m_xHeight) == 0 && m_ascent > 0)

Why the cast to int? WebKit style is to not write “== 0” and “!= 0”.

> +            m_xHeight = 0.66 * m_ascent;

Why 0.66? If you used 3 / 2 (or 66 / 100, I don’t know if the difference is meaningful) you could avoid float arithmetic here. Should this really be based the on the already-rounded m_ascent, and always rounded down, or would it be better to use fAscent and round to the nearest integer?

Do other ports besides Mac need a similar changed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.