[Webkit-unassigned] [Bug 45197] [GTK] Need a WebSocket implementation

Mon Sep 6 08:41:51 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45197

--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2010-09-06 08:41:51 PST ---
(In reply to comment #2)
> (From update of attachment 66558 [details])
> The only comment I have is why the socket source is created and stored at connection time if it's not going to be necessarily used (?).

Hmm. The GIO documentation seemed unclear about whether or not the reference to the GSocketClient needed to stick around until the connection was finished, so I figured it was safer to keep the reference until it was definitely unused.

> Or is writing less data than what we have in platformSend so common that it's worth to do things that way?

Yeah, we have to handle this. It also presents a good opportunity to start waiting for socket writability. It turns out that if you don't only do this when you need to, the GSource fires continuously and eats up all of your cycles.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.