[Webkit-unassigned] [Bug 45181] Ignore programmatic clicks on speech input button.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 6 06:52:18 PDT 2010


--- Comment #8 from Satish Sampath <satish at chromium.org>  2010-09-06 06:52:18 PST ---
> > LayoutTests/fast/speech/speech-button-ignore-generated-events.html:32
> > +    }, 500);
> this is flaky!!!!
> is there some number of setTimeouts that makes this deterministic?   or something like that?

I can't think of any way, since we are checking for an event NOT being fired. I see such timeouts exist in other tests (such as http://trac.webkit.org/browser/trunk/LayoutTests/fast/forms/script-tests/textarea-metrics.js?rev=66825#L46). I can increase it to 1 second if you think that may make it more deterministic.

> > LayoutTests/fast/speech/speech-button-ignore-generated-events.html:41
> > +    event.initMouseEvent('click', true, true, window, 1, pageX, pageY, clientX, clientY,
> is there any way to know for sure that this fired on the correct element?

Unfortunately no, this depends on where and how the speech button is rendered and that is not exposed to javascript. These UI related tests need to be updated when the speech button rendering code changes.

If these are ok, I can upload a new patch with the other comments fixed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list