[Webkit-unassigned] [Bug 43954] An individual renderer should be assigned to each SVGFE*Element class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43954


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66627|review?                     |review+
               Flag|                            |




--- Comment #6 from Dirk Schulze <krit at webkit.org>  2010-09-06 05:37:26 PST ---
(From update of attachment 66627)
View in context: https://bugs.webkit.org/attachment.cgi?id=66627&action=prettypatch

> WebCore/rendering/RenderObject.h:324
>      virtual bool isSVGResourceContainer() const { return false; }
>      virtual bool isSVGShadowTreeRootContainer() const { return false; }
> +    virtual bool isRenderSVGResourceFilterPrimitive() const { return false; }
Maybe we should name this isSVGResourceFilterPrimitive to be consistent with the other function names.

Please change the name everywhere you're using this function. Otherwise looks great. r=me with this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.