[Webkit-unassigned] [Bug 45142] [Qt] V8 port for QT platform: Use DateMath from WTF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45142





--- Comment #6 from Adam Barth <abarth at webkit.org>  2010-09-05 23:36:47 PST ---
(From update of attachment 66536)
View in context: https://bugs.webkit.org/attachment.cgi?id=66536&action=prettypatch

I was tempted to R- this patch because of the dependency issue, but I don't really understand the contraints here in enough detail.

> JavaScriptCore/wtf/DateMath.cpp:866
>  #if USE(JSC)
>  namespace JSC {
> +#elif USE(V8)
> +namespace V8 {
> +#endif
Woah, crazy.

> JavaScriptCore/wtf/DateMath.h:54
> +#if USE(V8) && PLATFORM(QT)
> +#include <v8.h>
> +#endif
This seems like a bad dependency.  I don't think code outside of WebCore/bindings/v8 is supposed to depend on v8.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.