[Webkit-unassigned] [Bug 45147] [Qt] V8 port for QT platform: Plugin changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45147


Andreas Kling <andreas.kling at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66454|review?                     |review-
               Flag|                            |




--- Comment #4 from Andreas Kling <andreas.kling at nokia.com>  2010-09-05 17:44:18 PST ---
(From update of attachment 66454)
> +#if PLATFORM(QT)
> +    #undef True
> +    #undef False

Why is this needed? There's no reference to it in the ChangeLog.

>  #if USE(JSC)
>          ScriptState* scriptState = parentFrame->script()->globalObject(pluginWorld())->globalExec();
> -#elif USE(V8)
> +#else
>          ScriptState* scriptState = 0; // Not used with V8
>  #endif

This part should be left alone.

> +// definition fits V8 and JSC

Unnecessary comment.
More importantly though, bindingInstance() will now be compiled but never used for Chromium. We should be nice and use an "#if USE(JSC) || (USE(V8) && !PLATFORM(CHROMIUM))" guard.

> +#else
> +#include "V8NPObject.h"
> +#endif

Should be "#elif USE(V8)".

r- because of the bindingInstance() on Chromium thing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.