[Webkit-unassigned] [Bug 45237] Add JSON parameter support to JS/V8 binding generator scripts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45237


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66593|review?                     |review-
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2010-09-04 17:06:59 PST ---
(From update of attachment 66593)
View in context: https://bugs.webkit.org/attachment.cgi?id=66593&action=prettypatch

> WebCore/bindings/scripts/CodeGeneratorJS.pm:235
> +    my $type = shift;
> +    return ("CREATE" => "boolean", "EXCLUSIVE" => "boolean") if $type eq "Flags";
This logic shouldn't be in the code generator.  You'll need to provide this information as input to the code generator.

> WebCore/bindings/scripts/CodeGeneratorJS.pm:240
> +    # For testing.
> +    return ("intAttr" => "long",
> +            "stringAttr" => "DOMString",
> +            "testObjAttr" => "TestObj") if $type eq "TestJSONObj";
Why do we have special code to support testing?  Doesn't that defeat the purpose of testing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.