[Webkit-unassigned] [Bug 45206] Add AudioProcessor.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45206


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66556|review?                     |review-
               Flag|                            |




--- Comment #2 from chris fleizach <cfleizach at apple.com>  2010-09-03 20:03:14 PST ---
(From update of attachment 66556)
>          Reviewed by Darin Adler.
> Index: WebCore/platform/audio/AudioProcessor.h
> ===================================================================
> --- WebCore/platform/audio/AudioProcessor.h	(revision 0)
> +++ WebCore/platform/audio/AudioProcessor.h	(revision 0)
> @@ -0,0 +1,73 @@
> +/*
> + * Copyright (C) 2010 Google Inc. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1.  Redistributions of source code must retain the above copyright
> + *     notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *     notice, this list of conditions and the following disclaimer in the
> + *     documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *     its contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
> + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
> + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> + * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
> + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
> + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
> + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +

wrong license
http://trac.webkit.org/browser/trunk/WebKit/LICENSE


> +#ifndef AudioProcessor_h
> +#define AudioProcessor_h
> +
> +namespace WebCore {
> +
> +class AudioBus;
> +
> +// AudioProcessor is an abstract base class which can be used as one part of a complex DSP algorithm.
> +// Or, it can be used as the processor for a basic (one input - one output) AudioNode.
> +// It's assumed that the number of input channels equals the number of output channels.
> +

if it's assumed, then you should say "output must equal input" so there's no confusion

> +class AudioProcessor {
> +public:
> +    AudioProcessor(double sampleRate)
> +        : m_initialized(false)
> +        , m_sampleRate(sampleRate)
> +    {
> +    }
> +
> +    virtual ~AudioProcessor() { }
> +
> +    // Full initialization can be done here instead of in the constructor.
> +    virtual void initialize() = 0;
> +    virtual void uninitialize() = 0;
> +

Why do you want initialize and uninitialize methods instead of using constructor/destructor?

> +    virtual void setNumberOfChannels(unsigned numberOfChannels) = 0;
> +

You don't need to name the argument here, it is clear from the function name.

> +    bool isInitialized() { return m_initialized; }
> +

can this be const?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.