[Webkit-unassigned] [Bug 45222] Add ability to send UserData to willSubmitForm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45222





--- Comment #4 from Adam Barth <abarth at webkit.org>  2010-09-03 19:49:06 PST ---
(From update of attachment 66581)
View in context: https://bugs.webkit.org/attachment.cgi?id=66581&action=prettypatch

Mostly just curious what this code looked like.  Very pretty.  Some (trivial) comments below.

> WebKit2/UIProcess/WebPageProxy.cpp:581
> -            willSubmitForm(process()->webFrame(frameID), process()->webFrame(sourceFrameID), textFieldValues, listenerID);
> +            willSubmitForm(process()->webFrame(frameID), process()->webFrame(sourceFrameID), textFieldValues, 0/*userData*/, listenerID);
Slightly more beautiful would be a noUserData constant that was just a null pointer.

> WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:513
> +    RefPtr<FormState> formState = prpFormState;
I've never really like this pattern, but I don't see a way around it.

> WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:520
> +    RefPtr<APIObject> userData;
> +    webPage->injectedBundleFormClient().willSubmitForm(webPage, form, m_frame, sourceFrame, values, userData);
I'm confused.  Don't we need to actually allocate a userData object here?  Does willSubmitForm take a RefPtr by reference as an out param?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.