[Webkit-unassigned] [Bug 39617] [GTK] Google sites do not like WebKitGTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39617





--- Comment #36 from Martin Robinson <mrobinson at webkit.org>  2010-09-03 13:56:17 PST ---
(From update of attachment 64328)
View in context: https://bugs.webkit.org/attachment.cgi?id=64328&action=prettypatch

> WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:96
> +typedef HashSet<String> GoogleDomainsSet;
This typedef is only used once, so perhaps it's unnecessary? I think that Vector<String> is fairly readable.

> WebKit/gtk/webkit/webkitwebsettings.cpp:207
> +    uaOSVersion = String::fromUTF8(osVersion.get());
Instead of using the GOwnPtr / g_strdup_printf here, is it possible to just use String::format?

I like this patch a lot, especially the use of DEFINE_STATIC_LOCAL. If Xan agrees, I think we can r+ this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.