[Webkit-unassigned] [Bug 44771] [GTK] Windowless Plugins - Initialize XEvent before passing to plugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44771





--- Comment #11 from Xan Lopez <xan.lopez at gmail.com>  2010-09-03 11:24:17 PST ---
(In reply to comment #10)
> +        No new tests needed since this is a trivial fix.
> 
> I don't see how one follows from another. Any patch that changes observable behavior needs a test.

This is correct, and now and in the past I have hold patches that were useful and needed of going into WebKit(GTK+) because they lacked the necessary tests. In this case the patch seems so obviously correct and trivial that I don't think we need to do this. I believe this is routinely done by everyone, and far more complicated patches have been landed without tests in WebKit by every single person commenting on this bug. If we are going to enforce this rule absolutely everywhere then let's do it, but please let's not enforce it randomly and without reason.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.