[Webkit-unassigned] [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44127





--- Comment #50 from W. James MacLean <wjmaclean at chromium.org>  2010-09-03 11:04:04 PST ---
(In reply to comment #48)
> > +    ASSERT(rect.size() == rootLayerTextureSize());
> 
> Shouldn't you be asserting that it's not larger than the rootLayerTextureSize?  It won't always be equal to it, right?

Correct, thanks.

> >  #if USE(ACCELERATED_COMPOSITING)
> >      } else {
> > +
> 
> nit: please remove the added newline

Done.

> The SkAutoLockPixels should move inside the if (rect==bitmapRect) 

OK. I thought it might be necessary for the drawBitmapRect call too.

> 
> const WebCore::IntRect&  ? 

Yup!

Could I ask if you can remove the excess code when you post a comment like this? Without coloured highlighting in the reply box (when I'm replying to your comments), it's hard to separate your comments from the code (I'm concerned about missing a comment somewhere).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.