[Webkit-unassigned] [Bug 45142] [Qt] V8 port for QT platform: Use DateMath from WTF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 10:20:23 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=45142





--- Comment #3 from Vlad <vladbph at gmail.com>  2010-09-03 10:20:23 PST ---
DateMath is used by /bridge/qt/qt_runtime... 

(In reply to comment #2)
> (From update of attachment 66435 [details])
> > +        [Qt] V8 port for QT platform: Use DateMath from WTF 
> 
> I'm sure there's a reason we need this from WTF, but could you expand on why? :-)

I got style failure, so I went and fixed that... 

> 
> > -            if (*dateString != ':') {
> > +            if (*dateString != ':')
> >                  offset = ((o / 100) * 60 + (o % 100)) * sgn;
> > -            } else { // GMT+05:00
> > +            else { // GMT+05:00
> 
> While correct, please avoid making unrelated style changes as it makes "svn blame" harder to use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list