[Webkit-unassigned] [Bug 39053] [GStreamer] cache media duration in READY instead of PLAYING

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 07:25:30 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39053





--- Comment #9 from Eric Carlson <eric.carlson at apple.com>  2010-09-03 07:25:30 PST ---
(From update of attachment 66480)
+        // Attempt to cache the duration, without emitting the
+        // durationchange event because it most likely was first sent
+        // by the media element when the ready state reached HAVE_METADATA.
+        durationChanged(false);
+

...

-    m_player->durationChanged();
+    if ((m_mediaDuration != previousDuration) && emitEvent)
+        m_player->durationChanged();
I don't understand why you would *ever* want to suppress the event. If you don't send the event when the duration changes, you won't ever send it unless the duration changes again. 

Why not always send it when m_mediaDuration != previousDuration?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list