[Webkit-unassigned] [Bug 43954] An individual renderer should be assigned to each SVGFE*Element class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43954





--- Comment #3 from Zoltan Herczeg <zherczeg at webkit.org>  2010-09-03 06:52:16 PST ---
Thanks for the review.

> > WebCore/rendering/RenderSVGFilterPrimitive.cpp:37
> > +namespace WebCore {
> > +
> > +
> > +
> > +} // namespace WebCore
> > +
> Ok, this file is useless at the moment. It should be added once the logic gets added.

Would double the efforts of managing build systems. Do you insist of adding it later?

> Again, the patch looks realy great. I wounder and am happy that this patch fixes tests instead of breaking tests. Did you run all SVG-tests? Great job so far.

Yeah. Actually that test was working on Qt but not on mac. After discussing the issue with Niko, I just landed it until we could fix it somehow. I am also happy this patch fixes it, and no need to debug why that is wrong :)

Other things are ok, I will do the changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.