[Webkit-unassigned] [Bug 26276] Need a mechanism to determine stack extent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26276


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66474|                            |review?
               Flag|                            |




--- Comment #5 from Xan Lopez <xan.lopez at gmail.com>  2010-09-02 23:30:06 PST ---
Created an attachment (id=66474)
 --> (https://bugs.webkit.org/attachment.cgi?id=66474)
interpreteroverflow.diff

First crack at this.

I'm using the same idiom that JSParser uses. I copied the value to calculate an end address from there, since I'm unsure of whether we want to share it or not. If we do, we should probably have it in some header (where?), if we want a different value here we just need to change it.

WRT tests, there's actually a few tests that check for stack overflow in parsing, execution, ...(eg, js1_5/Regress/regress-192414.js, js1_5/Regress/regress-192465.js ), but we could write more if you think our coverage is not enough. In any case, no regressions here with this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.