[Webkit-unassigned] [Bug 45141] [Qt] V8 port for QT platform: webcore project files changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45141


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laszlo.1.gombos at nokia.com




--- Comment #2 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-09-02 19:47:53 PST ---
1./ Instead of 

+contains(QTJAVASCRIPTENGINE, V8) {
+    WEBCORE_INCLUDEPATH = \
+        $$PWD/../v8.$$QTJAVASCRIPTENGINEREV/include \
+        $$PWD/bindings/v8 \

I would recommend 

+contains(QTJAVASCRIPTENGINE, V8) {
+    WEBCORE_INCLUDEPATH = \
+        $$PWD/../$$V8_DIR/include \
+        $$PWD/bindigs/v8

2./ Instead of repeating the wtf source files in WebCore.pro I think it is time to create a wtf.pri under JavaScriptCore/wtf.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.