[Webkit-unassigned] [Bug 45006] Add AudioListener files

Thu Sep 2 16:22:22 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45006

Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66141|review?                     |review+
               Flag|                            |

--- Comment #3 from Kenneth Russell <kbr at google.com>  2010-09-02 16:22:22 PST ---
(From update of attachment 66141)
Looks fine to me. I was going to argue about the naming of setOrientation taking the six double arguments, but see that that's exposed in the JavaScript API. It might be worth a FIXME at the top to change this to using FloatPoint3D rather than Vector3 once FloatPoint3D has been moved to a more general place than platform/graphics. (Or you could just cut it over now in anticipation of the move.) You could also consider switching over to single-precision floating point numbers everywhere in the implementation if they provide sufficient precision and range.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.