[Webkit-unassigned] [Bug 44960] [chromium] fix memory corruption in Khmer rendering.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44960


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66279|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #16 from Adam Barth <abarth at webkit.org>  2010-09-02 15:46:29 PST ---
(From update of attachment 66279)
View in context: https://bugs.webkit.org/attachment.cgi?id=66279&action=prettypatch

This review is more of a rubber stamp rely upon the comments above.

> WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp:72
> +    unsigned codepoints = 0;
> +    for (hb_uint32 i = 0; i < length; i++) {
> +      if (!SkUTF16_IsHighSurrogate(characters[i]))
> +        codepoints++;
> +      if (codepoints > *glyphsSize)
> +        return 0;
> +    }
This code needs four-space indent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.