[Webkit-unassigned] [Bug 45020] Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Thu Sep 2 12:16:24 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45020

Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66174|review?                     |review-
               Flag|                            |

--- Comment #4 from Dave Hyatt <hyatt at apple.com>  2010-09-02 12:16:24 PST ---
(From update of attachment 66174)
This patch is missing the "bt" value for the block-flow property.  I only see "tb", "rl" and "lr".

I'd prefer descriptive names for the block flow direction rather than the abbreviations.  Instead of BFLR, BFLR, BFTB, I'd prefer:

LeftToRightBlockFlow, RightToLeftBlockFlow, TopToBottomBlockFlow, BottomToTopBlockFlow

I would go ahead and add computed style support (see CSSComputedStyleDeclaration) for the new properties to this patch, since that will enable you to have actual tests that verify that the values are being parsed and inherited correctly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.