[Webkit-unassigned] [Bug 43629] Use correct minus glyphs in MathML operators

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 07:57:04 PDT 2010


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #66352|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #10 from Darin Adler <darin at apple.com>  2010-09-02 07:57:04 PST ---
(From update of attachment 66352)
> +inline UChar convertHyphenMinusToMinusSign(UChar glyph)
> +{
> +    // When rendered as a mathematical operator, minus glyph should be larger.
> +    if (glyph == hyphenMinus)
> +        return minusSign;
> +    return glyph;
>  }

I don't think this needs to be in the RenderMathMLOperator.h file. It could just as well be private in the .cpp file.

Thanks for making this more of a "why" comment. It still is slightly oblique, but I can't figure out an easy way to make it more direct.

Otherwise, patch seems fine.

I’ll set both the review flag and the commit-queue flag, but if you would like to make the function private, you could clear the commit-queue one.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list