[Webkit-unassigned] [Bug 44329] SH4 JIT SUPPORT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44329


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paroga at paroga.com




--- Comment #2 from Patrick R. Gansterer <paroga at paroga.com>  2010-09-02 07:31:44 PST ---
I'm not a reviewer but this patch is a clear r-:
1) Missing ChangeLog
2) You change many independent things in one patch
3) You change introduce stuff noone uses. E.g.:
> +#if defined(__sh__)
> +#define WTF_CPU_SH 1
> +#endif
> +
There is no check for CPU(SH) in the code.
4) You cange wrong things. E.g.:
> -#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC) && defined(NDEBUG)
> +#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC) && defined(NDEBUG) || CPU(SH4)
>  #define FORCE_SYSTEM_MALLOC 0
>  #else
>  #define FORCE_SYSTEM_MALLOC 1
This is the wrong place for a CPU(SH4)

See http://webkit.org/coding/contributing.html for more information.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.