[Webkit-unassigned] [Bug 44669] [Qt] Make it possible to configure QtWebKit to use V8

Wed Sep 1 16:37:35 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44669

Andreas Kling <andreas.kling at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|PC                          |All
         OS/Version|Mac OS X 10.5               |All
           Keywords|                            |QtTriaged
         AssignedTo|webkit-unassigned at lists.web |webkit-qt-unassigned at trollt
                   |kit.org                     |ech.com
                 CC|                            |andreas.kling at nokia.com

--- Comment #23 from Andreas Kling <andreas.kling at nokia.com>  2010-09-01 16:37:34 PST ---
Hi Vlad, interesting work!

Three things before we can start proper reviews:

1. Some of your patches replace the entire contents of files with what seems to be mostly the same data. Could this be due to newline format mismatch perhaps? Needs to be fixed.

2. ChangeLog entries are missing. You can use WebKitTools/Scripts/prepare-ChangeLog to generate boilerplate entries. See https://trac.webkit.org/wiki/QtWebKitContrib for more information.

3. (Admittedly of lesser importance) There's both "#if USE(JSC) ... #elif USE(V8) ..." and "#if USE(JSC) ... #else ...". I think we should stick with the first variant.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.