[Webkit-unassigned] [Bug 42716] Implement WebArchive for Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42716





--- Comment #8 from Elliott Slaughter <eds at google.com>  2010-09-01 10:36:07 PST ---
(In reply to comment #7)
> (From update of attachment 63010 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=63010&action=prettypatch
> 
> > WebCore/loader/archive/ArchiveFactory.cpp:68
> > +#elif PLATFORM(ANDROID)
> > +    mimeTypes.set("application/x-webarchive-xml", archiveFactoryCreate<WebArchiveAndroid>);
> Why the wacky MIME type?  Something more sensical would be application/x-webarchive+xml.  Even more sensical would be to use the existing webarchive MIME type.

We chose a different mime type because the format we used doesn't make use of the xml plist format, and uses custom xml instead. If you still think that using the same mimetype is warranted (even though the formats really aren't compatible), then I can make that change as suggested.

> > WebCore/loader/archive/android/WebArchiveAndroid.cpp:26
> > +#define LOG_TAG "webarchive"
> What is this?

That's Android's logging, will remove.

Thanks for the comments!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.