[Webkit-unassigned] [Bug 44958] Add support for autocorrection UI on Mac OS X.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44958





--- Comment #20 from mitz at webkit.org  2010-09-01 09:16:58 PST ---
(From update of attachment 66171)
One last comment:

> +    enum TextCheckingOptions {
> +        MarkSpelling = 1 << 0,
> +        MarkGrammar = 1 << 1,
> +        PerformReplacement = 1 << 2,
> +        ShowCorrectionPanel = 1 << 3,
> +    };
> +    void markAllMisspellingsAndBadGrammarInRanges(int textCheckingOptions, Range* spellingRange, Range* grammarRange);

The way these flags enums usually work in WebKit is that in addition to an enum for the flags, there is also a typedef for the bitmask, which is used as the parameter type:

    enum TextCheckingOptionFlags {
        MarkSpelling = 1 << 0,
        MarkGrammar = 1 << 1,
        PerformReplacement = 1 << 2,
        ShowCorrectionPanel = 1 << 3,
    };
    typedef unsigned TextCheckingOptions;

    void markAllMisspellingsAndBadGrammarInRanges(TextCheckingOptions, Range* spellingRange, Range* grammarRange);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.