[Webkit-unassigned] [Bug 39582] [Cairo] Enhance the performance of shadowed elements by tiling the shadow area

Wed Sep 1 07:38:09 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39582

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66179|review?                     |review+
               Flag|                            |

--- Comment #43 from Martin Robinson <mrobinson at webkit.org>  2010-09-01 07:38:09 PST ---
(From update of attachment 66179)
View in context: https://bugs.webkit.org/attachment.cgi?id=66179&action=prettypatch

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:628
> +    // drawTiledShadow still does not work with rotations
Please add a period to the end of this sentence before landing.

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1442
> +    // drawTiledShadow still does not work with rotations
Same here.

This looks good to me. Eventually much of this should be separated out into another class. We should share ContextShadow. I think I'll start on that today. We need to ensure that shadows for non-rectangular shapes are fast as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.