[Webkit-unassigned] [Bug 44957] Web Inspector, Extension API: Panel.onSelectionChanged event is never fired

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44957





--- Comment #7 from Andrey Kosyakov <caseq at chromium.org>  2010-09-01 06:06:01 PST ---
(In reply to comment #5)
> (From update of attachment 66073 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66073&action=prettypatch
> 
> > WebCore/inspector/front-end/ExtensionServer.js:225
> > +            var result = window.eval(
> I believe we can get rid of this eval by providing the function body directly or even call the eval without wrapping it into an anonymous function as we discussed offline. A bigger problem is that this code doesn't allow extensions to declare global functions, r- for this.

The latter happened to be not the case: the code being evaluated still runs in global context. Added a test for that, though, and rewrote wrapper code to a shorter (though less readable) version without outer function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.