[Webkit-unassigned] [Bug 44837] Web Inspector: persist DOM breakpoints between page reloads

Wed Sep 1 02:38:26 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44837

Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66047|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #7 from Yury Semikhatsky <yurys at chromium.org>  2010-09-01 02:38:26 PST ---
(From update of attachment 66047)
View in context: https://bugs.webkit.org/attachment.cgi?id=66047&action=prettypatch

> WebCore/inspector/front-end/DOMAgent.js:804
> +        WebInspector.DOMBreakpoint._ids = {};
Why do we need both integer and string type value? We should either use strings or intergers everywhere, r- for this. Given that the backend uses integers and we have named constants in the frontend it seems like we may well get rid of string values.

> WebCore/inspector/front-end/DOMAgent.js:842
> +        WebInspector.DOMBreakpoint._contextMenuLabels[WebInspector.DOMBreakpoint.Types.NodeRemoved] = WebInspector.UIString("Break on Node Removal");        
Revert this please.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.