[Webkit-unassigned] [Bug 44957] Web Inspector, Extension API: Panel.onSelectionChanged event is never fired

Wed Sep 1 01:48:24 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44957

Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66073|review?                     |review-
               Flag|                            |

--- Comment #5 from Yury Semikhatsky <yurys at chromium.org>  2010-09-01 01:48:24 PST ---
(From update of attachment 66073)
View in context: https://bugs.webkit.org/attachment.cgi?id=66073&action=prettypatch

> WebCore/inspector/front-end/ExtensionServer.js:225
> +            var result = window.eval(
I believe we can get rid of this eval by providing the function body directly or even call the eval without wrapping it into an anonymous function as we discussed offline. A bigger problem is that this code doesn't allow extensions to declare global functions, r- for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.