[Webkit-unassigned] [Bug 39582] [Cairo] Enhance the performance of shadowed elements by tiling the shadow area

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39582





--- Comment #40 from Alejandro G. Castro <alex at igalia.com>  2010-09-01 00:29:13 PST ---
Thanks for the review :)

(In reply to comment #39)
> (From update of attachment 66129 [details])
> > WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:630
> > +    if ((transform.isIdentityOrTranslationOrFlipped())) {
> > +        cairo_t* cr = context->platformContext();;
> Avoid multiple braces and muliple semicolons.
> 
> > WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:633
> > +        FloatSize corner(0, 0);
> No need for (0, 0), just use FloatSize corner;
> 
> > WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1330
> > +    OwnPtr<ImageBuffer> smallBuffer = ImageBuffer::create(smallBufferSize);
> You should check if we realy got an imagebuffer.
> 

Good catch this one, there are more places int he code without this check, I'll change it in the patch and create a new bug for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.