[Webkit-unassigned] [Bug 48308] Too precise serialization from floating point number to string for "number" input elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48308





--- Comment #14 from Dai Mikurube <dmikurube at google.com>  2010-10-31 20:29:05 PST ---
(From update of attachment 72456)
View in context: https://bugs.webkit.org/attachment.cgi?id=72456&action=review

>> WebCore/html/NumberInputType.cpp:132
>>      // Accepts erros in lower fractional part which IEEE 754 single-precision
> 
> The comment should be moved to NumberInputType::acceptableError().

Moved. Thanks.

>> WebCore/html/parser/HTMLParserIdioms.cpp:71
>> +    static const unsigned NumberToStringBufferLength = 96;
> 
> Why don't you use NumberToStringBuffer and NumberToStringBufferLength in dtoa.h?

It's because NumberToStringBuffer and -Length is just for numberToString(). Currently serializeForNumberType() doesn't use numberToString(), so I stopped to use NumberToStringBuffer here.
(I removed #include <dtoa.h>. I forgot to remove it.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.