[Webkit-unassigned] [Bug 48516] GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48516





--- Comment #30 from Dirk Schulze <krit at webkit.org>  2010-10-31 12:11:49 PST ---
(From update of attachment 72179)
View in context: https://bugs.webkit.org/attachment.cgi?id=72179&action=review

The design looks good. A CG guy should look at the code GraphicsContextCG changes. Kling will also run pixeltests with this patch, to make sure that we don't get regressions.

> WebCore/platform/graphics/GraphicsContext.h:306
>  

Add a fixme, that these functions are deprecated.

> WebCore/platform/graphics/cg/GraphicsContextCG.cpp:307
> -    CGContextRef context = platformContext();
> -    CGContextBeginPath(context);
> -    float r = (float)rect.width() / 2;
> -    CGContextAddArc(context, rect.x() + r, rect.y() + r, r, 0.0f, 2.0f * piFloat, 0);
> -    CGContextClosePath(context);
> -
> -    drawPath();
> +    Path path;
> +    path.addEllipse(rect);
> +    drawPath(path);

Not sure, if the code in PathCG looks identical, if not, this will change some pixel tests (maybe just visible with a tolerance of 0)

> WebCore/platform/graphics/cg/GraphicsContextCG.cpp:399
> +static Path createConvexPolygonPath(size_t numPoints, const FloatPoint* points)

Doesn't this give back a copy of the created Path?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.