[Webkit-unassigned] [Bug 48094] Setting globalAlpha on canvas and drawing a video does not honor alpha value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48094





--- Comment #24 from Aaron Colwell <acolwell at chromium.org>  2010-10-29 15:24:46 PST ---
(In reply to comment #23)
> (In reply to comment #21)
> > (In reply to comment #20)
> > > This check-in caused the Qt and GTK bots to start failing, because the test requires video. This needs to be added to the Skipped list, presumably. Aaron, you should ideally fix this yourself, putting a patch for the issue into a new bug report.
> > 
> > I don't understand what you are asking me to do. The little "qt" & "gtk" boxes next to the patch are green. Isn't that supposed to indicate whether I broke something? Can you point me to instructions on how to do what you want. Also what should I do differently to avoid this in the future.
> 
> As James Robinson explained, the EWS checks to see if you break compiling on other platforms. Your patch compiles on those platforms, but introduced tests that fail on those platforms.
> 
> The instructions for this are on <http://webkit.org/coding/contributing.html> in the section “Keeping the tree green”. The instructions are part of the project too, so if you find they are missing something we can take patches to add what you learn to them.
> 
> You may need to get on IRC and talk to some Qt and GTK experts to learn what to do and exactly how to do it. Or you may need 1-on-1 help from someone with experience landing WebKit patches.

ok. Sorry about this. Newbie mistake. The patch is available here
https://bugs.webkit.org/show_bug.cgi?id=48688

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.