[Webkit-unassigned] [Bug 48450] [Qt] Extend the Platform Plugin to define the padding of HitTestResult

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48450





--- Comment #8 from Andre Pedralho <andre.pedralho at gmail.com>  2010-10-29 10:48:23 PST ---
(In reply to comment #6)
> (From update of attachment 72241 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72241&action=review
> 
> Looks great!
> 
> > WebKit/qt/Api/qwebkitplatformplugin.h:113
> > +    enum PaddingDirection {
> > +        Up, Right, Down, Left
> > +    };
> 
> Is not it against the webkit style?
> 
Sorry, I just followed the style of the other extensions.

> > WebKit/qt/ChangeLog:15
> > +        (TouchAdjuster::setHitTestPadding):
> 
> you do not have the setter anymore, and it is not called touchadjuster neither.
> 
Ops! Forget to update Changelog and commit header.

> > WebKit/qt/examples/platformplugin/WebPlugin.cpp:254
> > +        return new TouchInteraction();
> 
> who deletes it?
Ok! I'll add a private QObject* m_extension variable and delete it in the plugin destructor. Other suggestion?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.