[Webkit-unassigned] [Bug 48555] ASSERT when SVGAnimatedProperty instance is assigned to multiple elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48555





--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-29 06:47:24 PST ---
Heh, I didn't think about calling insertItemBefore on a SVGLengthList with a SVGLength parameter that is not in a list, but just associated with a SVGAnimatedLength object.
The fix is easy, my tree is just not clean yet:


        int removedIndex = animatedPropertyOfItem->removeItemFromList(newItem, livesInOtherList);
        ASSERT(removedIndex != -1);

Replace that assertion by

        // If the item is not present in a list, we don't need to remove it.
        if (removedIndex == -1)
            return;

And remove the ASSERT_NOT_REACHED() in SVGAnimatedProperty.h.
We could add a "virtual bool isSVGAnimatedListProperty" method to SVGAnimatedProperty, to stop "abusing" removedIndex = -1 as indicator for "item is not member of a list". But I'll come to that in a later patch.

As soon as my tree is clean, I'll prepare a patch, or if you're faster just go ahead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.