[Webkit-unassigned] [Bug 48516] GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48516





--- Comment #17 from Nikolas Zimmermann <zimmermann at kde.org>  2010-10-29 03:40:04 PST ---
(In reply to comment #16)
> (In reply to comment #15)
> > I'm not talking about GraphicsContext::addPath. In cg Path wraps a CGPath object, and CGContextAddPath just takes a CGPathRef (handle to the CGPath). That is _not_ a copy.
> 
> And I was more thinking about Cairo. And we do a lot of cairo_copy_path there.

I wanted to move the discussion towards _our_ API, and how we can avoid copying Path, and making the GraphicsContext API nicer. I'd like to reach consensus about that first, then look at the individual graphic libraries.

Path foobar;
foobar.addRect(...);

context->fillPath(foobar);
context->strokePath(foobar);
seems like a nice API, where fill/strokePath take a const Path&, to avoid a copy.

Do we all agree on that? If so, let's look at how we can implement that kind of API efficiently in CG/Qt/GTK/Skia. If we'll then reach the point, where we need changes in the design, we can continue discussing that, but I'd like to see a nice API proposal first, and here's mine, which is I think exactly like Andreas (we discussed it before, btw.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.