[Webkit-unassigned] [Bug 48516] GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48516





--- Comment #6 from Andreas Kling <kling at webkit.org>  2010-10-29 00:08:32 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > New suggestion: how about replacing beginPath()+addPath() with setPath(const Path&) (since that's how it's used anyway) and not expecting strokePath() or fillPath() to touch the current path?
> 
> Like you said, setPath would make use of beginPath()+addPath() anyway. So where is the improvement, if fillPath() and strokePath don't use the currentPath?

IMO it would make the API less ambiguous - why have the concept of "addPath" when we're never actually adding multiple paths?

For Qt, there's the additional advantage that we don't have a "platform beginPath()" so setPath() means a little less work for us.

> Btw, why doesn't fillPath or strokePath on Qt close the currentPath?

It does both, actually.

> Nevertheless, it's ok to use setPath, but I'd still let fillPath and strokePath use the currentPath, just make sure that we don't close/clear the path and do it manually instead.

I like this idea, though I'm not sure what the best way to do that on CG is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.