[Webkit-unassigned] [Bug 48450] [Qt] Extend the Platform Plugin to define the padding of HitTestResult

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48450


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72241|                            |commit-queue-
               Flag|                            |




--- Comment #6 from Antonio Gomes <tonikitoo at webkit.org>  2010-10-28 21:37:45 PST ---
(From update of attachment 72241)
View in context: https://bugs.webkit.org/attachment.cgi?id=72241&action=review

Looks great!

> WebKit/qt/Api/qwebkitplatformplugin.h:113
> +    enum PaddingDirection {
> +        Up, Right, Down, Left
> +    };

Is not it against the webkit style?

> WebKit/qt/ChangeLog:15
> +        (TouchAdjuster::setHitTestPadding):

you do not have the setter anymore, and it is not called touchadjuster neither.

> WebKit/qt/examples/platformplugin/WebPlugin.cpp:254
> +        return new TouchInteraction();

who deletes it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.