[Webkit-unassigned] [Bug 45982] Web Inspector: FileSystem integration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45982


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72216|review?                     |review+
               Flag|                            |




--- Comment #30 from Pavel Feldman <pfeldman at chromium.org>  2010-10-28 12:54:50 PST ---
(From update of attachment 72216)
View in context: https://bugs.webkit.org/attachment.cgi?id=72216&action=review

> WebCore/inspector/InspectorFileSystemAgent.cpp:128
> +    for (Frame* frame = mainFrame; frame; frame = frame->tree()->traverseNext()) {

nit: you should pass mainFrame into the traverseNext

> WebCore/inspector/front-end/inspector.js:55
> +    fileSystemOrigins: {},

I really don't like polluting our global namespace with public maps like this. I am currently getting rid of the nastiest one, the WebInspector.resources. It is painful to see the new ones coming. They belong to the corresponding panels. I'd like to see this fixed in the follow up change.

> WebCore/inspector/front-end/inspector.js:1296
> +                // This should match the SecurityOrigin::toString(). FIXME: Add a test for this.

I'd like to see the test in the follow up change please.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.