[Webkit-unassigned] [Bug 48495] webkit-patch land -g HEAD started failing, leaving uncommitted ChangeLog's

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48495


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abarth at webkit.org,
                   |                            |aroben at apple.com




--- Comment #1 from Ojan Vafai <ojan at chromium.org>  2010-10-28 09:29:59 PST ---
Unfortunately, webkit-patch land has always had this issue. webkit-patch land -g only works if the changelog doesn't need to be modified.

It occurs to me that this could be fixed by reordering some code. Right now, the way it works for committing a specific commit:
1. Update the changelogs based off the bug
2. Create a dummy branch
3. Cherry pick the given commit to the dummy branch
4. Commit the dummy branch
5. Switch back to the original branch

In theory, we could do step 1 after step 3 and everything would work right. As the code is currently structured, that might be a bit tricky, but it's possible.

I don't have time to fix this, but I'd be happy to review a patch that did.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.