[Webkit-unassigned] [Bug 48496] Add WebKit2 API for window feature getter/setters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48496


John Sullivan <sullivan at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72133|review?                     |review-
               Flag|                            |




--- Comment #4 from John Sullivan <sullivan at apple.com>  2010-10-28 06:33:32 PST ---
(From update of attachment 72133)
There's a mixture of naming styles here, e.g.:

WebChromeClient: setMenubarVisible/menubarVisible
WebUIClient: setMenuBarIsVisible/menuBarIsVisible
MiniBrowser/TestController: setMenuBarVisible/getMenuBarVisible

The AppKit conventions that we generally try to match are none of the above -- those conventions would specify: setMenuBarVisible (or setMenubarVisible) / isMenuBarVisible (or isMenubarVisible).

I don't care whether the B in Menubar is capitalized or not, but we should try to match existing style in WebKit if there are precedents. Of the other styles, I would pick the AppKit style, but if there's some reason to use a different style then we should use it consistently.

The content all seems fine but I think we need to get the names more consistent so I'm giving this an r-.


 In WebChromeClient you' MiniBrowser you're using getMenuBarVisible/setMenuBarVisible (etc.) whereas in WebUIClient you're using getMenuBarIsVisible/setMenuBarIsVisible

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.