[Webkit-unassigned] [Bug 48506] New: Move DeviceOrientationClientMock from LayoutTestController to WebViewHost

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48506

           Summary: Move DeviceOrientationClientMock from
                    LayoutTestController to WebViewHost
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jknotten at chromium.org
                CC: steveblock at google.com, hans at chromium.org


The test fast/dom/DeviceOrientation/no-page-cache.html opens an additional
window which results in a secondary page with its own
DeviceOrientationController. Since DeviceOrientationClientMock maintains a back
pointer to the corresponding WebCore::Page's DeviceOrientationController, there
should be one DeviceOrientationClientMock per DeviceOrientationController. 

In DumpRenderTree (unlike test_shell) there is only one instance of
LayoutTestController. LayoutTestController owns WebDeviceOrientationClientMock
which owns DeviceOrientationClientMock, so there is only one instance of the
mock that must serve two controllers (in the above test).

There is exactly one WebViewHost instance per WebView (per page). I propose that
we move the mock to WebViewHost, and that
LayoutTestController::setMockOrientation delegates to the TestShell's primary
WebView.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.