[Webkit-unassigned] [Bug 25536] WebKit needs to expose an Element::spellcheck attribute to javascript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25536





--- Comment #7 from MORITA Hajime <morrita at google.com>  2010-10-28 01:29:58 PST ---
Hi, Kent-san, Sam, thank you for taking a look!
I updated the patch.

> > LayoutTests/editing/spelling/script-tests/spelling-attribute-change.js:25
> > +    shouldBe("layoutTestController.hasSpellingMarker(6, 2)", enabled ? "true" : "false");
> 
> Some ports has no hasSpellingMarker() implementation, right? We need to skip the test on them.
Yes, only Mac, windows and chromium-mac support spellchecking.
Added skip entries for other ports.

> 
> > WebCore/html/HTMLElement.cpp:735
> > +    setAttribute(HTMLNames::spellcheckAttr, enable ? "true" : "false");
> 
> Need no HTMLNames::.
Removed.

> > WebCore/html/HTMLElement.idl:65
> > +                 attribute boolean spellcheck;
> 
> This should probably use the [Reflect] extended attribute which would mean you don't need the implementation of spellcheck/setSpellcheck in HTMLElement.h/cpp
Oh, I didn't notice this. Thank you pointing this out.
In this case, I'd use explicit implementation
because spellcheck has nontrivial semantics like inheritance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.