[Webkit-unassigned] [Bug 48227] [GTK] Handle surrogate pairs in TextBreakIteratorGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48227


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72020|review?                     |review-
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2010-10-28 00:07:34 PST ---
(From update of attachment 72020)
View in context: https://bugs.webkit.org/attachment.cgi?id=72020&action=review

Very nice! I just have a couple very small comments.

> WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp:31
> +using namespace std;

I think I'd prefer the functions you're using to be explicit here.

using std::max; for example.

> WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp:33
> +#define IS_SURROGATE(character) (character >= 0x10000 && character <= 0x10FFFF)

I think this should probably be called UTF8_IS_SURROGATE just to be clear that it deals with UTF-8 characters.

> WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp:77
> +    long utf8len = 0;

According to the style guidelines, this should be utf8Length.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.