[Webkit-unassigned] [Bug 48494] fix setSize() order in WebP image decoding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48494


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72144|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #8 from Adam Barth <abarth at webkit.org>  2010-10-27 22:18:49 PST ---
(From update of attachment 72144)
View in context: https://bugs.webkit.org/attachment.cgi?id=72144&action=review

> WebCore/ChangeLog:3
> +        Reviewed by NOBODY (OOPS!).

This line is ok because the tools fill in the reviewer automatically for you.

> WebCore/ChangeLog:6
> +        fix setSize() call flow: it was only called the first
> +        time (when onlySize is true)

Also, you should link to the bug from the ChangeLog so folks can find it from the SVN revision history.

> WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

There's an SVN pre-commit hook that rejects OOPS in files.  This line will prevent the patch from being landed.  You should replace this line with an explanation of why there is no test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.